adobe / helix-publish

Microservice for publishing Project Helix Fastly service configurations
Apache License 2.0
5 stars 6 forks source link

request removes mount root #139

Closed tripodsan closed 5 years ago

tripodsan commented 5 years ago

Description a request to https://adobedevsite.helix-demo.xyz/open/index.html removes the open form the backend request:

$ curl -D - https://adobedevsite.helix-demo.xyz/open/index.html?a=1 -H X-Debug:true
HTTP/2 500
x-version: 319; src=319; cli=2.2.1; rev=online
x-url: //index.html?a=1
x-backend-url: /api/v1/web/developer-adobe-com/helix-services/experimental-dispatch@latest?static.owner=adobe&static.repo=developer.adobe.com&static.ref=bundling-and-optimization&static.root=/htdocs&content.owner=adobe&content.repo=developer.adobe.com&content.ref=bundling-and-optimization&content.root=&content.package=github-com--adobe--developer-adobe-com--bundling-and-optimization-dirty&content.index=index.html&path=//index.html&strain=open-dev&params=

although the strain is mapped to

  - name: open-dev
    <<: *devDefaults
    url: https://adobedevsite.helix-demo.xyz/open
    package: developer-adobe-com/c397c173b4dfeaaba3ffbcd1ce429f0bec3c6a24

running it locally gives:

[hlx] info: request url: /open/index.html
[hlx] info: request path: /open/index.html
[hlx] info: action path: /index.md
[hlx] info: action rootPath: /open
[hlx] info: strain header: open-dev

running it remotely shows:

2019-07-16T00:48:36.917Z       stdout: info: request url: //index.html
2019-07-16T00:48:36.918Z       stdout: info: request path: //index.html
2019-07-16T00:48:36.918Z       stdout: info: action path: //index.md
2019-07-16T00:48:36.918Z       stdout: info: action rootPath: undefined
2019-07-16T00:48:36.918Z       stdout: error: Exception during #13/once:once from 
tripodsan commented 5 years ago

also, it used to send those headers:

    this._wskHeaders = Object.assign({
      'X-Openwhisk-Activation-Id': this._wskActivationId,
      'X-Request-Id': this._requestId,
      'X-Backend-Name': 'localhost--F_Petridish',
      'X-CDN-Request-ID': this._cdnRequestId,
      'X-Strain': this._strain.name,
      'X-Old-Url': this._url,
      'X-Repo-Root-Path': repoPath,
    }, this._headers);

which should be forwarded by experimental dispatch to the action

tripodsan commented 5 years ago

the problem is, that the rooPath parameter was removed from the VCL.

adobe-bot commented 5 years ago

:tada: This issue has been resolved in version 2.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: