Icon should not be tracked

adobe / helix-rum-enhancer

Add advanced functionality to Helix RUM Collection (client-side)

Apache License 2.0

2 stars 12 forks source link

Icon should not be tracked #203

Open kptdobe opened 3 weeks ago

kptdobe commented 3 weeks ago

With https://github.com/adobe/helix-rum-enhancer/pull/196, the picture > img selector has been replaced with img. For Helix sites, this means will start tracking icons as soon as a site uses enhancer@v2. This is where we should start having different code for Helix sites vs "CQ" site vs generic site for tracking.

cc @trieloff

trieloff commented 3 weeks ago

@davidnuescheler always complained that the icon was not tracked. "The icon should be the most popular image on every site". So I agree on the sentiment, but don't like the idea of different code bases yet.