adobe / helix-rum-enhancer

Add advanced functionality to Helix RUM Collection (client-side)
Apache License 2.0
1 stars 14 forks source link

feat: add more logic to button selector #205

Closed kptdobe closed 3 months ago

kptdobe commented 3 months ago

Fix #204 by adding more logic to try to compute a selector to identify the (clicked) button. Probably not perfect but should at least cover the onetrust popup and some basic dom combo.

kptdobe commented 3 months ago

The problem is that buttons like accept / reject / close from the consent dialog or geoloc popup falls into the same category. We also started to use the RUM collection for product usage where you need to know which of the button has been clicked.

It could be fine to prefix all of them but button | to classify them together and have details in the second part.

trieloff commented 3 months ago

The consent dialog is not a conversion. The geolocation dialog is not a conversion.

Also, I think source should always look like a CSS selector, so | isn't great either.

github-actions[bot] commented 3 months ago

This PR will trigger a minor release when merged.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.61%. Comparing base (f70df99) to head (c863b57). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #205 +/- ## ========================================== + Coverage 67.70% 68.61% +0.90% ========================================== Files 5 5 Lines 483 497 +14 ========================================== + Hits 327 341 +14 Misses 156 156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 3 months ago

:tada: This PR is included in version 2.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: