Closed kptdobe closed 3 months ago
The problem is that buttons like accept
/ reject
/ close
from the consent dialog or geoloc popup falls into the same category.
We also started to use the RUM collection for product usage where you need to know which of the button has been clicked.
It could be fine to prefix all of them but button |
to classify them together and have details in the second part.
The consent dialog is not a conversion. The geolocation dialog is not a conversion.
Also, I think source
should always look like a CSS selector, so |
isn't great either.
This PR will trigger a minor release when merged.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.61%. Comparing base (
f70df99
) to head (c863b57
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:tada: This PR is included in version 2.15.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Fix #204 by adding more logic to try to compute a selector to identify the (clicked) button. Probably not perfect but should at least cover the onetrust popup and some basic dom combo.