adobe / helix-rum-enhancer

Add advanced functionality to Helix RUM Collection (client-side)
Apache License 2.0
1 stars 14 forks source link

Improve test coverage through integration tests #226

Closed trieloff closed 3 months ago

trieloff commented 3 months ago

This has been a bit more painful than I expected. The integration test now loads helix-rum-enhancer through a (slightly prepared) version of helix-rum-js and then validates the checkpoints that have been sent using a mocked navigator.sendBeacon. This helps to bring up the coverage of index.js, but there are still good chunks of it that require more fiddling, especially when we look at URL parameter comprehension

adobe-bot commented 3 months ago

This PR will trigger no release when merged.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.58%. Comparing base (bb71ae6) to head (baaf738). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #226 +/- ## =========================================== + Coverage 73.83% 84.58% +10.75% =========================================== Files 5 5 Lines 493 493 =========================================== + Hits 364 417 +53 + Misses 129 76 -53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 2 months ago

:tada: This issue has been resolved in version 2.17.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: