search

adobe / helix-rum-enhancer

Add advanced functionality to Helix RUM Collection (client-side)
Apache License 2.0
1 stars 14 forks source link

feat(audience): validate and anonymize reported audience #235

Open ramboz opened 2 months ago

ramboz commented 2 months ago

Introducing data validation and pre-processing logic to properly validate experiment and audience checkpoints, which will be dependent on the opt-in logic, and also pre-process the reported audience to anonymize it.

Related Issues

Fix https://github.com/adobe/helix-rum-collector/issues/360

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.78351% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.79%. Comparing base (8805b49) to head (43f6233). Report is 1 commits behind head on main.

Files Patch % Lines
modules/index.js 85.71% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #235 +/- ## =========================================== - Coverage 100.00% 98.79% -1.21% =========================================== Files 6 6 Lines 488 583 +95 =========================================== + Hits 488 576 +88 - Misses 0 7 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ramboz commented 2 months ago

@trieloff I can work with the DOM. We do set a CSS class for any experiment and/or audience so code-only ones can trigger appropriately. So I could hook into that logic and skip the explicit sampleRUM call indeed

adobe-bot commented 2 months ago

This PR will trigger a minor release when merged.

ramboz commented 2 weeks ago

@trieloff Is there anything left before we can approve and merge this? I see 1 failing test, but that seems related to the newly introduced language checkpoint.