adobe / helix-rum-enhancer

Add advanced functionality to Helix RUM Collection (client-side)
Apache License 2.0
1 stars 14 forks source link

feat: deliver src folder #294

Open kptdobe opened 1 week ago

kptdobe commented 1 week ago

Use our infrastructure to deliver the distribution files (which are in the src folder....)

https://dist-deliver--helix-rum-enhancer--adobe.aem.page/src/index.js 200 Do not expose the source: https://dist-deliver--helix-rum-js--adobe.aem.page/modules/index.js 404

aem-code-sync[bot] commented 1 week ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [1a92523](https://github.com/adobe/helix-rum-enhancer/commit/1a92523896736033c05a07924576039ac888dd4d) :white_check_mark: (latest) * [47c98f5](https://github.com/adobe/helix-rum-enhancer/commit/47c98f5bcfe4e0f2012de5c3ce7cbcb71ec55029) :white_check_mark:
aem-code-sync[bot] commented 1 week ago
Page Scores Audits Google
:iphone: /src/index.js Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/javascript). PSI
:desktop_computer: /src/index.js Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/javascript). PSI
:iphone: /modules/index.js PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /modules/index.js PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 63.20755% with 156 lines in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (03be852) to head (47c98f5).

Files with missing lines Patch % Lines
src/index.js 63.20% 156 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ============================================ - Coverage 100.00% 84.29% -15.71% ============================================ Files 6 7 +1 Lines 569 993 +424 ============================================ + Hits 569 837 +268 - Misses 0 156 +156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 1 week ago

This PR will trigger a minor release when merged.

bosschaert commented 1 week ago

Quick question - are the files under /src automatically updated when a release is made?

kptdobe commented 1 week ago

In theory yes, that's the change in .releaserc. But we'll need to merge and make a release to know...

kptdobe commented 1 week ago

And the src folder is not necessary in the PR, it should be created by the release. I just added it so we can test the delivery.