adobe / helix-rum-js

Helix RUM Event Generator for JavaScript
Apache License 2.0
1 stars 8 forks source link

feat: improving enhancer loading timing #175

Closed kptdobe closed 3 months ago

kptdobe commented 4 months ago

Introduces a new capability: let the consumer define when to load the enhancer. To do so:

github-actions[bot] commented 4 months ago

This PR will trigger no release when merged.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (830fd72) to head (32fc673).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #175 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 66 69 +3 ========================================= + Hits 66 69 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 2 months ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

trieloff commented 2 months ago

This seems to be messing with https://github.com/adobe/helix-rum-enhancer/pull/256 need to understand why

trieloff commented 2 months ago

Faster loading of rum-enhancer in the default behavior means that the URL manipulation needed for the test is coming too late. Fixed in https://github.com/adobe/helix-rum-enhancer/pull/256/commits/bd2eae39df4784dfb85c0e4a8d166748837dffd5