feat: improve errors capture

adobe / helix-rum-js

Helix RUM Event Generator for JavaScript

Apache License 2.0

1 stars 8 forks source link

feat: improve errors capture #189

Closed kptdobe closed 2 months ago

kptdobe commented 3 months ago

While looking at the error tracking, I realized there are some inconsistencies like:

if error occur in the HTML file, the source appears as at https://... while if error occurs in a JS file it shows functionname@https://... - addressed by the PR
we have a lot of source: undefined error (and no target) - while this might be the case for unhandled promise rejections, code could try to identify a better source and target for those cases.

I also wrote tests to cover all different scenarii.

github-actions[bot] commented 3 months ago

This PR will trigger a minor release when merged.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (332739c) to head (89bcc34).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #189 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 1 2 +1 Lines 69 175 +106 ========================================== + Hits 69 175 +106 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 2 months ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

trieloff commented 2 months ago

2.2.0 fails in https://github.com/adobe/helix-rum-enhancer/pull/256 - I don't think it's related to these changes, but better to check.