search

adobe / helix-rum-js

Helix RUM Event Generator for JavaScript
Apache License 2.0
1 stars 8 forks source link

feat: Make sampleRUM function available to other scripts for standalone usage #208

Closed cziegeler closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (006a902) to head (49f0a94). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #208 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 178 178 ========================================= Hits 178 178 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kptdobe commented 1 month ago

A description would be great to describe the use cases...

We want to avoid this and ideally, everything should be tracked automatically... what are use cases which are not tracked... ?

cziegeler commented 1 month ago

I guess there will always be use cases where the ootb instrumentation is not enough and so far the use case we had is the forms add-on for AEM which wants to track additional things. Another use case is the 404 tracking, which we solved differently by providing an additional script for that use case. Now, currently the documentation of this project explicitly mentions the API for custom sampleRUM calls - and obviously even without this PR it is easily doable, just a little bit more ugly. I'm fine if there is a decision to not allow this, but then the documentation should be updated.

cziegeler commented 1 month ago

thanks, so closing this now