adobe / helix-rum-js

Helix RUM Event Generator for JavaScript
Apache License 2.0
1 stars 8 forks source link

feat(enhancer-version): allow selecting a specific enhancer version in standalone #214

Closed chicharr closed 4 days ago

chicharr commented 1 month ago

Fixes: #203

Allow users of standalone distribution to provide a specific enhancer version, and a md5 hash

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (af1a21c) to head (383c511). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 183 187 +4 ========================================= + Hits 183 187 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cziegeler commented 1 month ago

@chicharr Looks good to me, but what about the 404 script?

cziegeler commented 2 weeks ago

@chicharr As mentioned, the PR looks good, but the same needs to be applied to the standalone 404 script

github-actions[bot] commented 2 weeks ago

This PR will trigger a minor release when merged.

chicharr commented 2 weeks ago

@chicharr As mentioned, the PR looks good, but the same needs to be applied to the standalone 404 script

@cziegeler @kptdobe @trieloff PR is updated with the changes in 404.js

adobe-bot commented 4 days ago

:tada: This PR is included in version 2.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: