adobe / helix-rum-js

Helix RUM Event Generator for JavaScript
Apache License 2.0
1 stars 8 forks source link

feat(standalone): Use data attribute for 404 tracking (avoid separate script) #225

Closed cziegeler closed 5 days ago

cziegeler commented 5 days ago

Currently we create two scripts standalone and standalone-404 - which are mainly identical, with the exception that the latter is used for tracking 404 responses. With the recent introduction of using the navigation API into the standalone script, it makes sense to merge the functionality into a single script.

This patch uses the data-status attribute to inform the script of a 404 response, instead of using a separate script.

For now we should still create the standalone-404 until we can phase it out

aem-code-sync[bot] commented 5 days ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [a793f13](https://github.com/adobe/helix-rum-js/commit/a793f13851080ce85bcfaf80e03f9a1da323c6b5) :white_check_mark: (latest)
adobe-bot commented 5 days ago

:tada: This PR is included in version 2.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: