Closed langswei closed 9 months ago
This PR will trigger a minor release when merged.
I think it is weird to do this in a for loop when both
UPDATE
andINSERT INTO
are perfectly fine in accepting a series of rows.
@trieloff Good call, check now.
Updated table function in BQ and no further run-query changes required. Tested and works.
:tada: This PR is included in version 3.16.0 :tada:
The release is available on:
v3.16.0
v3.16.0
Your semantic-release bot :package::rocket:
As part of the RUM for AEM CS initiative, we are getting requests for 100s of domains to share a single domain key. It would be a nice convenience to create the domain key for all domains in one request.
This PR is to document and discuss a change to the table function helix_reporting.ROTATE_DOMAIN_KEYS which is a pre-requisite to a run-query change. Upon approval, I will make the table function change in BigQuery and move on to the run-query changes.
This change is backward compatible -- a single domain may still be passed in. A test implementation exists at helix_reporting.ROTATE_DOMAIN_KEYS_MULTIPLE for now.