search

adobe / helix-run-query

service that executes queries on BigQuery datasets generated by Helix-Logging
Apache License 2.0
6 stars 11 forks source link

fix: short-circuit rum-dashboard query if invalid domain key #1148

Closed langswei closed 3 months ago

langswei commented 3 months ago

Added short-circuit to prevent main query from running if the domainkey+url combination is invalid. The existing implementation scans a lot of data even if the domain key is known to be invalid.

If satisfied, we can roll this out to other run-queries. So far I could not find a way to handle this more narrowly only in EVENTS_V5.

Test at /run-query@ci7821/rum-dashboard. My testing showed identical results for both valid and invalid domainkeys between v3 and ci7821.

trieloff commented 3 months ago

:tada: This PR is included in version 3.30.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: