adobe / helix-run-query

service that executes queries on BigQuery datasets generated by Helix-Logging
Apache License 2.0
6 stars 11 forks source link

feat(events_v5): ignore invalid weights in EVENTS_V5 #1158

Closed lydiapuric closed 3 months ago

lydiapuric commented 3 months ago

Please ensure your pull request adheres to the following guidelines:

Related Issues

[RUM] Filter fake weights from EVENTS_V5 #1157

Thanks for reviewing!

lydiapuric commented 3 months ago

@trieloff I looked at the failing post-deploy integration tests for the RUM Dashboard, and this looks like an issue with the blown-up weights. This test is failing since Friday, June 28th.

Error I see: Query error: int64 out of range: 1e+20 at [52:1]

1) Post-Deploy Tests (AWS) https://**********.execute-api.*********.amazonaws.com/helix-services/run-query/ci7902
       RUM Dashboard:

      AssertionError [ERR_ASSERTION]: 500 == 200
      + expected - actual

      -500
      +200

      at Context.<anonymous> (file:///home/circleci/project/test/post-deploy.test.js:34:14)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
trieloff commented 3 months ago

:tada: This PR is included in version 3.32.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: