search

adobe / helix-run-query

service that executes queries on BigQuery datasets generated by Helix-Logging
Apache License 2.0
6 stars 11 forks source link

If domainkey is wrong can we provide a non-authorized response body? #912

Open MarquiseRosier opened 1 year ago

MarquiseRosier commented 1 year ago

Is your feature request related to a problem? Please describe. currently if domain key is wrong; here's what we return, Screen Shot 2023-07-13 at 9 09 11 AM

Describe the solution you'd like if we can give a 401 status code vs a response with a data field in the body of the response, this would be more helpful for consumers of the api!

issue raised by David Barrat of the DAAS team

dbrrt commented 1 year ago

@MarquiseRosier Another note on the domainKey. It'd be a better practice to have it in the headers rather than as a query parameter since as a query parameters, it'll be visible in the query logs.