search

adobe / helix-sidekick-extension

Browser extension for authors on AEM projects
Apache License 2.0
21 stars 37 forks source link

Unlocalised string "Invalid hostname" in Options > Edit #700

Closed Adobe-G11N-I18N-L10N-Team closed 6 months ago

Adobe-G11N-I18N-L10N-Team commented 7 months ago

Description String "Invalid hostname" is unlocalized

To Reproduce Steps to reproduce the behavior:

  1. Install AEM sidekick extension
  2. Go to project folder in Google Drive
  3. Click on extension button > "Add this project"
  4. Right click on extension button -> "Options"
  5. Click "Edit" button in "Projects"
  6. Enter "1" character in "Production Hostname (optional)"

Expected behavior String is localized

Additional context String is localized in GLaaS String ID: config_invalid_host#message

Screenshots 6 41 1 fra 6 41 1 jpn

rgeraghty commented 6 months ago

@rofe fix is part of PR https://github.com/adobe/helix-sidekick-extension/pull/706/files

Adobe-G11N-I18N-L10N-Team commented 6 months ago

Issue is still reproduce 700_strill_repro_ja_JP

rofe commented 6 months ago

@Adobe-G11N-I18N-L10N-Team that's because the issue is still open.

trieloff commented 6 months ago

:tada: This issue has been resolved in version 6.42.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Adobe-G11N-I18N-L10N-Team commented 6 months ago

Issue is no longer reproduce 700_fixed_ja_JP