fix: Authorization header is not sent for page subresources

adobe / helix-sidekick-extension

Browser extension for authors on AEM projects

Apache License 2.0

21 stars 39 forks source link

fix: Authorization header is not sent for page subresources #791

Closed andreituicu closed 3 months ago

andreituicu commented 3 months ago

The current implementation of the sidekick is only sending the authorization header for the main document, but not for the subresources (scripts, stylesheets, images, etc.). This PR ensures that all subresources are loaded when helix 5 authentication is enabled and the page renders.

Before:

After:

andreituicu commented 3 months ago

@rofe @dylandepass : Could I please ask for a review on this PR? Thank you! (it looks like I'm not added to the repo so I can't use the github feature for asking reviews)

andreituicu commented 3 months ago

@dylandepass @rofe : May I please ask for write permissions to merge the PR? Alternatively, of course, you guys could merge it for me. Thank you! 🙂

rofe commented 3 months ago

@andreituicu i can merge it tomorrow.