search

adobe / helix-sidekick

Browser-based helper for authors on Helix projects
Apache License 2.0
4 stars 10 forks source link

[JSON Preview] Integer value breaks the rendering #235

Closed kptdobe closed 2 years ago

kptdobe commented 2 years ago

In a Google spreadsheet, add a column with an integer value and hit the Preview button: in the JSON Preview, you will see the header rows but no value and JS error in the logs:

failed to draw view TypeError: value.startsWith is not a function
    at drawValue (json.js:29:13)
    at json.js:78:7
    at Array.forEach (<anonymous>)
    at json.js:76:22
    at Array.forEach (<anonymous>)
    at drawBody (json.js:74:8)
    at json.js:110:5
    at Array.forEach (<anonymous>)
    at draw (json.js:101:23)
    at showSpecialView (module.js:1094:9)

Faulty value is the integer one.

See preview for https://main--bamboohr-website--lamontacrook.hlx3.page/blog-query-index.json

rofe commented 2 years ago

This needs to be fixed in https://github.com/adobe/helix-sidekick

trieloff commented 2 years ago

:tada: This issue has been resolved in version 3.36.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: