search

adobe / helix-sidekick

Browser-based helper for authors on Helix projects
Apache License 2.0
4 stars 10 forks source link

Enable sidekick publish on files in `.helix/` #306

Closed dylandepass closed 2 years ago

dylandepass commented 2 years ago

As part of the content-bus config merge users will need to be able to publish the .helix/headers.json file.

Files contained in .helix/ will continue to be blocked from being served via the pipeline but the preview/publish operations in admin will trigger a merge of all config files into .helix/confilg-all.json and /helix-env.json. Where the latter does not contain any sensitive data from .helix/config.json and can be used by other helix systems (besides pipeline) to extract the production host.

dylandepass commented 2 years ago

@tripod pointed out that we don't really need to publish .helix/config.json and when merging we should just pull this from preview. So I've updated this issue to only allow publish operations on .helix/headers.json. That said I can see a world where in the future were potentially we want to enable publish on other files in .helix/.

rofe commented 2 years ago

So basically, only .helix/config.json should be treated as a special case?

cc @tripodsan

tripodsan commented 2 years ago

So basically, only .helix/config.json should be treated as a special case?

cc @tripodsan

for now, I would just disable publish on all /.helix. we can still open it up if needed.

rofe commented 2 years ago

OK, that's the current status. Then I don't understand this enhancement request. 😄

tripodsan commented 2 years ago

right, I forgot that there is no publish button on the edit urls. closing as won't fix.

dylandepass commented 2 years ago

Sorry, somehow missed this convo..

.helix/config-all.json is unique to each partition as per. https://github.com/adobe/helix-html-pipeline/blob/main/src/steps/fetch-config-all.js#L103

If we are not going to enable publish we should do something similar to what is done with preview operations on .helix/config where somehow (haven't looked) a preview results in .helix/config-all.json in the live partition being updated.

Do you agree @tripodsan?

tripodsan commented 2 years ago

I think /.helix/headers.json should also not need a publish.