search

adobe / helix-simulator

Apache License 2.0
4 stars 9 forks source link

Live Reload #445

Closed trieloff closed 4 years ago

trieloff commented 4 years ago

Inject something like the https://github.com/livereload/livereload-js and let helix-simulator push a feed of updated files (from the fs watcher) to the client

kptdobe commented 4 years ago

I do not see the use case yet, apart from CSS reload which is easy to handle with a bookmarklet. Images, we don't need. LESS, SASS, we don't do yet.

Full reload, maybe for the config (helix-config, fstab) or the content. Well... hlx up already tracks for changes (restart the Helix server on change) but also opens a browser window for you, can't it just reload this window in case of a change ?

tripodsan commented 4 years ago

well, livereload does more than just reload the window. from my experience when working with react/vue, any change to the JS/CSS (HTL) trigger a rebuild and redeploy to the browser. In constrast to the CSS-reload bookmarklet, this happens on push, and also if you change <style>...</style> code in your HTL.

And: it would come out-of-the box :-)

tripodsan commented 4 years ago

I'll look into it....

kptdobe commented 4 years ago

from my experience when working with react/vue, any change to the JS/CSS (HTL) trigger a rebuild and redeploy to the browser.

This usually ends up being a full reload because you cannot (and Live Reload has the same issue) reload JS in the majority of the cases. Only CSS (it is really cool) and this can be achieved with the no-cost bookmarklet.

if you change <style>...</style> code in your HTL

We did not do that yet.

With one identified pb (css hot reload), we are going to build a complex machinery to cover a lot of hypothetical use cases that, for now, we do not have or nobody is asking for. The customer (@davidnuescheler) was happy with the proposed solution. This is a perfect example on how we should not build software in 2020. But I agree, it would be cool :)

adobe-bot commented 4 years ago

:tada: This issue has been resolved in version 4.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: