adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
25 stars 40 forks source link

Refactor: clean up dependencies, JS CDN usage, chart loading #531

Closed trieloff closed 4 months ago

trieloff commented 4 months ago

This refactoring cleans up the code quite a bit:

  1. instead of using a smattering of CDNs to load dependencies from, we use only one
  2. instead of loading dependendencies sometimes as UMD, somethimes as ESM, only use ESM
  3. use ESM Import Maps to specify dependencies per HTML file
  4. slicer.js no longer loads all possible charts, the correct chart to use is injected by the HTML

chart.js's adapter system (which we need for date/time and sankey) requires dependencies to be strictly aligned. Both our external dependencies pin chart.js@4.4.0 so I'm upgrading them to 4.4.2 – this is not just for consistency, but to ensure functionality

aem-code-sync[bot] commented 4 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [35608d2](https://github.com/adobe/helix-website/commit/35608d28f9108c994cc177b0cd8ccefc2240a698) :white_check_mark: (latest) * [76a7d7f](https://github.com/adobe/helix-website/commit/76a7d7fe1b38f828164bda9a7b1c44b2cf66ebc8) :white_check_mark: * [385b9f5](https://github.com/adobe/helix-website/commit/385b9f59f74b6628c1f82a4e1cc218c650e65cd7) :white_check_mark: * [a43139e](https://github.com/adobe/helix-website/commit/a43139e7efd72940dd669a6759f44d3e674ec2d8) :white_check_mark: * [db8650e](https://github.com/adobe/helix-website/commit/db8650e71a9feed1f4bf4e8efea1a7249b66bfd7) :white_check_mark: * [b1f3dae](https://github.com/adobe/helix-website/commit/b1f3dae91397a07a0a98165f4fee56ac5493daa1) :white_check_mark: * [93f0b16](https://github.com/adobe/helix-website/commit/93f0b167d6c063c5da42dcbd6f964887874f96a6) :white_check_mark: * [a6a34b0](https://github.com/adobe/helix-website/commit/a6a34b0864ce35bc802bf5a0a8fa45f450fcbe24) :white_check_mark: * [5a805bf](https://github.com/adobe/helix-website/commit/5a805bfc01faf7f191b1caf2f2b5cd98de696c5b) :white_check_mark: * [1d26598](https://github.com/adobe/helix-website/commit/1d2659844a5291c2bdbbc010032cf26d1bdf6055) :white_check_mark: