adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
24 stars 35 forks source link

feat: add pagespeed insights link #554

Closed langswei closed 3 weeks ago

langswei commented 4 weeks ago

Add link to PageSpeed Insights in URL facet

Description

Added a link to PageSpeed Insights for each given URL in the URL facet.

Related Issue

Motivation and Context

Meant to give a clue to users how to diagnose issues and make it faster to do so even if they don't need the clue.

How Has This Been Tested?

https://pagespeed--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=emigrationbrewing.com&filter=&view=month&domainkey=open&conversion.checkpoint=click

Screenshots (if appropriate):

Screenshot 2024-06-07 at 3 12 41 PM

Types of changes

Checklist:

aem-code-sync[bot] commented 4 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [bc54c97](https://github.com/adobe/helix-website/commit/bc54c975d2e491bbceec9529917866163a7946e0) :white_check_mark: (latest) * [ba0e051](https://github.com/adobe/helix-website/commit/ba0e05104d402257ba60bcc8b8ab4a6132382967) :white_check_mark: * [a582e14](https://github.com/adobe/helix-website/commit/a582e1461f80c0308ca93b06af96600fa350fb9a) :white_check_mark:
aem-code-sync[bot] commented 4 weeks ago
Page Scores Audits Google
/tools/rum/explorer.html?domain=emigrationbrewing.com&filter=&view=month&domaink
ey=open&conversion.checkpoint=click
PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
trieloff commented 4 weeks ago

The page speed icon should not be an img – we can add that in CSS, maybe with something like this https://codepen.io/trieloff-the-flexboxer/pen/qBGXjxx

langswei commented 3 weeks ago

The page speed icon should not be an img – we can add that in CSS, maybe with something like this https://codepen.io/trieloff-the-flexboxer/pen/qBGXjxx

I probably missed your point on this -- I had only read the initial comment which showed up in email, not the edited one here which is more pure CSS. Anyways have a look and advise if I should abandon that one.

https://github.com/adobe/helix-website/pull/555