adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
25 stars 40 forks source link

feat(rum-oversight): split draw from loadData #625

Closed karlpauls closed 1 month ago

karlpauls commented 1 month ago

Currently, the loadData method is calling draw at the end. This causes some duplicated call to the draw method of the chart - it doesn't really seem to be a performance problem (nor cause other issues) but it seems it would make some sense to move the draw call out of loadData and invoke it explicitly when needed.

Test: https://slicerdraw--helix-website--karlpauls.hlx.page/tools/oversight/explorer.html?domain=aem.live&domainkey=

aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
M /tools/oversight/explorer.html?domain=aem.live&domainkey= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /tools/oversight/explorer.html?domain=aem.live&domainkey= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
kptdobe commented 1 month ago

Can we also get the patch for the explorer ?