adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
25 stars 40 forks source link

feat(rum-oversight): improve matching in consent #628

Closed karlpauls closed 1 month ago

karlpauls commented 1 month ago

The matching in consent maps over all possibilities. Replacing it with find can shortcut the evaluation as only one match is required.

Description

Replace the map in consent with a find and delay the actual look up of the target.

Motivation and Context

Trying to improve the speed of consent matching.

How Has This Been Tested?

Looking at the ui rendering speed in the console at https://consentmatching--helix-website--karlpauls.hlx.page/tools/oversight/explorer.html?domain=aem.live&domainkey=

aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
M /tools/oversight/explorer.html?domain=aem.live&domainkey= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /tools/oversight/explorer.html?domain=aem.live&domainkey= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI