adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
25 stars 40 forks source link

feat: no reload #660

Open kptdobe opened 1 week ago

kptdobe commented 1 week ago

Why reloading the full page while a simple redraw should do the job and avoid the flicker.

Redrawing might require to fetch a different set of data if the view, startDate or endDate is changed. I noticed also that when there are a lot of data to fetch (like 1GB when loading adobe.com week view), the UI might feel unresponsive. I have added a loading spinner and disabled all facets.

https://no-reload--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=www.adobe.com

aem-code-sync[bot] commented 1 week ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [520d1bc](https://github.com/adobe/helix-website/commit/520d1bcabdc5258b341905e5a6acd1bd6dc627a7) :white_check_mark: (latest) * [5400a3a](https://github.com/adobe/helix-website/commit/5400a3affaecbb9b8f0eabbe1b77c4df29b8dbc4) :white_check_mark: * [533a86e](https://github.com/adobe/helix-website/commit/533a86e7c27135b975ce9d1ca64a1ba1d744d089) :white_check_mark:
aem-code-sync[bot] commented 1 week ago
Page Scores Audits Google
:iphone: /tools/rum/explorer.html?domain=blog.adobe.com PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /tools/rum/explorer.html?domain=blog.adobe.com PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
vdua commented 1 week ago

@kptdobe the code doesn't fetch the data when you increase the range (week to month or month to year).

https://github.com/user-attachments/assets/3e99554d-c134-41a2-a34e-f1e81cdae2d0