adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
26 stars 41 forks source link

fix: only init rum if prerendered page becomes active #665

Closed kptdobe closed 1 month ago

kptdobe commented 1 month ago

To avoid collecting to many data, rum needs to be initialised only when prerendered pages become active. See https://github.com/adobe/aem-lib/issues/101.

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [3d8918e](https://github.com/adobe/helix-website/commit/3d8918e8a80c85466ed7136794fce32ee1ed2011) :white_check_mark: (latest)
trieloff commented 1 month ago

As I've said on the other issue and PR, this is a reporting issue, not a data collection issue. We should exclude bundles that are pre-rendered only from the count of page views, but we may want to continue counting them for things like content requests.

kptdobe commented 1 month ago

I agree with @trieloff.