Smart Redirects - Githubissues

adobe / helix-website

The Helix website https://www.aem.live/

https://www.aem.live

Apache License 2.0

26 stars 41 forks source link

Smart Redirects #670

Closed trieloff closed 1 month ago

trieloff commented 1 month ago

The tests requires a change to 404.html which only applies to main, therefore I've written unit tests.

Our example smart-redirects.json sheet has a redirect pattern rule from /documentation/* to /docs/*

feat(404): create error page from boilerplate
feat(404): apply smart redirects, but don't send 404 checkpoint if a redirect has been found
test(smartredirects): add tests for the meat of the code

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [449387b](https://github.com/adobe/helix-website/commit/449387ba178d72ff64408c0cd2b1c9c4d289cf7b) :white_check_mark: (latest) * [a2eacf2](https://github.com/adobe/helix-website/commit/a2eacf279424a812976b6237068c3d669bcba501) :white_check_mark: * [6fe592c](https://github.com/adobe/helix-website/commit/6fe592c3e59e469644f3202057536dc712c40fee) :white_check_mark:

davidnuescheler commented 1 month ago

i think it would be great to add a check to make sure that the 301 is not going to a 404, not super urgent in rev one...