search

adobe / htlengine

An HTL (Sightly) Interpreter/Compiler for Node.js
Apache License 2.0
47 stars 20 forks source link

itemList shorthand is broken #272

Closed benoit-adobe closed 3 years ago

benoit-adobe commented 3 years ago

It used to work but seems to be broken since the lowercase/uppercase insensitive updates. For instance, it breaks when trying to render the WCM Core Components carousel with the error: ReferenceError: itemlist is not defined. As a note, the carousel is using data-sly-repeat.

tripodsan commented 3 years ago

thanks for the issue. can you provide an example?

benoit-adobe commented 3 years ago

@tripodsan it happens when trying to render the carousel from the WCM Core Components with the JSON data examples from AEM Components site's examples, and the error is: ReferenceError: itemlist is not defined.

It used to work with a previous version of the htlengine but I am not sure which one to be honest (it seems to be broken since the lowercase/uppercase insensitive updates but not really sure).

I tried to change itemList to itemlist in the HTL template but it errors with the same message.

tripodsan commented 3 years ago

it's probably from here: https://github.com/adobe/aem-core-wcm-components/blob/8e9280e9241e63face5a81a5b4744888ef24a0e1/content/src/content/jcr_root/apps/core/wcm/components/carousel/v1/carousel/carousel.html#L36

benoit-adobe commented 3 years ago

@tripodsan FYI, itemList is a feature part of list/HTL, see list section in https://experienceleague.adobe.com/docs/experience-manager-htl/using/htl/block-statements.html?lang=en#htl.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 6.2.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket: