adobe / htlengine

An HTL (Sightly) Interpreter/Compiler for Node.js
Apache License 2.0
47 stars 20 forks source link

6.3.4 adds Proxy and breaks IE11 support #303

Closed jantimon closed 3 years ago

jantimon commented 3 years ago
function createTemplateGroup() {
  return new Proxy({ }, {
    get: (obj, key) => obj[key.toLowerCase()],
    set: (obj, key, value) => {
      // eslint-disable-next-line no-param-reassign
      obj[key.toLowerCase()] = value;
      return true;
    },
  });
}

this code causes multiple issues for us:

createTemplateGroup().keys() doesn't work anymore and breaks https://github.com/jantimon/htl-template-loader/blob/3ea0f0ee163fdc5c6b0e882d4174c6b269d78c99/lib/template-api.js#L130-L131

Proxy is not supported in IE11

Is there any way to parse data-sly-call="${headlineTemplate.headlineDemo}?
Because in that case we wouldn't need to compile incorrect code and fix it in the runtime with a Proxy

tripodsan commented 3 years ago

ok...I look for a different option...

but who in his right mind still uses IE 11 ? :-))


less than 4%: https://www.statista.com/statistics/272697/market-share-desktop-internet-browser-usa/

jantimon commented 3 years ago

Unfortunately most of our clients who can afford using AEM are giant corporations which are still using IE11 internally :(

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 6.3.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kuddl commented 3 years ago

@tripodsan Thanks a lot for fixing of the issues about proxy and lowercase so quickly. It really helped a lot and was much appreciated. Keep up the great work! 👏 👍 💯