Fix various build problems - Githubissues

adobe / hyde

A front-end to Jekyll that parses C++ sources to produce and enforce out-of-line documentation

http://opensource.adobe.com/hyde/

MIT License

323 stars 41 forks source link

Fix various build problems #70

Closed mowijo closed 2 years ago

mowijo commented 2 years ago

Description

Ignoring a multiline comment in LLVM9 as a -Wno-commend in the CMakeLists.txt
Adding return statements to methods where gcc cannot deduct that a case will always result in a return being executed.

Related Issue

https://github.com/adobe/hyde/issues/69

Motivation and Context

Why is this change required? This change is required to build on Ubuntu 20.04 with LLVM9 What problem does it solve? This enables building on Ubuntu 20.04 with LLMV9

How Has This Been Tested?

I didn't find any automated tests to fun, but I ran the

Screenshots (if appropriate):

N/A

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] N/A ~~I have added tests to cover my changes.~~
[X] N/A- I could not find any tests to run. ~~All new and existing tests passed.~~

fosterbrereton commented 2 years ago

LGTM; thank you for these changes!