search

adobe / inside-aem

Apache License 2.0
1 stars 6 forks source link

feat: animated highlight for addition of new post in AEM fact-box #78

Closed asthabh23 closed 10 months ago

asthabh23 commented 10 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #77

Test URLs:

aem-code-sync[bot] commented 10 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits
/en/drafts/aem-pla-blog-weekly-fact-check-edge-delivery-services PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
mtilburgadobe commented 10 months ago

Hi @asthabh23 , a couple questions

  1. the scrolling looks good, but I wonder what is the action for the user when they see it. It does not seem to be clickable. If I see this, the expectation is to go back to the homepage (or which ever page the content is displaying) and find the article?
  2. Does the article need to be published before the highlight is displayed?
asthabh23 commented 10 months ago

Hi @mtilburgadobe

  1. this scrolling is just as an fyi to the user who is on fact-box page.
  2. IIUC, this functionality is part of just the fact-box for now. so when the fact-box page is published, this scrolling (highlight) should be part of it. please let me know if you meant something different.
mtilburgadobe commented 10 months ago

IIUC, this functionality is part of just the fact-box for now. so when the fact-box page is published, this scrolling (highlight) should be part of it. please let me know if you meant something different.

I see this now. Got it, no problem!