adobe / leonardo

Generate colors based on a desired contrast ratio
http://www.leonardocolor.io
Apache License 2.0
1.97k stars 108 forks source link

"colorSpace" key does not work when written in camel-case #190

Closed skylerknight closed 1 year ago

skylerknight commented 1 year ago

Description

Color space is not set when using camel-case colorSpace, but works when using all lowercase colorspace

In the documentation code snippets, it shows as camel-case.

Expected behavior

I feel like it should be using camel-case, similar to colorKeys OR the code snippets should be changed to match. Not sure if this was already fixed in later versions. But leaving a note just in case.

Screenshots

Screen Shot 2022-12-10 at 12 53 11 PM

Leonardo package and version

@leonardo-contrast-colors version: 1.0.0-alpha.13

Environment

GarthDB commented 1 year ago

Agreed, we should probably standardize on either "colorspace" or "color space" (and colorSpace).

I'm leaning toward 2 words, so camel case, as you've suggested @skylerknight.

NateBaldwinDesign commented 1 year ago

This is a good call out. Camel case would be consistent with other parameters.