adobe / leonardo

Generate colors based on a desired contrast ratio
http://www.leonardocolor.io
Apache License 2.0
1.94k stars 104 forks source link

chore: update moon config to use Node v20.11 #233

Closed karstens closed 6 months ago

karstens commented 6 months ago

Description

Leonardo should use latest NodeJS LTS version, setup with moon and via a partial version specification: https://moonrepo.dev/docs/concepts/toolchain#version-specification

Note: Setting the node version in the toolchain.yml to an LTS alias, like 'lts/iron' will still give a warning about the version not matching, because moon sync will put the node version value from the toolchain.yml into the package.json, if given as an alias, but a partial version will be used properly, see this example for version with alias.

➜  leonardo git:(karstens/fix--set-node-version-to-lts) ✗ pnpm moon sync projects
 WARN  Unsupported engine: wanted: {"node":"lts/iron"} (current: {"node":"v20.11.1","pnpm":"8.15.3"})

Motivation

Screenshots

To-do list

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: 3f1033b4d4913154421e88bad1f8b5033d8ddc90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

GarthDB commented 6 months ago

Run report for 3f1033b4

Total time: 24.9s Comparison time: 23.2s Estimated loss: 1.7s (6.9% slower) Action Time Status Info
🟩 SyncWorkspace 0ms Passed
🟩 SetupNodeTool(~20.11) 4s Passed
🟩 InstallNodeDeps(~20.11) 8.5s Passed
🟩 SyncNodeProject(contrast-colors) 0.2ms Passed
🟩 SyncNodeProject(ui) 0.3ms Passed
🟩 RunTask(contrast-colors:test) 2.5s Passed
🟩 RunTask(ui:makeDistDir) 69.9ms Passed
🟩 RunTask(ui:copyCNAME) 61.1ms Passed
🟩 RunTask(ui:copyUIIcons) 61.1ms Passed
🟩 RunTask(ui:copyWorkflowIcons) 42.4ms Passed
🟩 RunTask(ui:buildSite) 9.9s Passed
Touched files
``` .moon/toolchain.yml package.json ```
karstens commented 6 months ago

@GarthDB please have a look.

➜  leonardo git:(karstens/fix--set-node-version-to-lts) pnpm moon sync projects

> leonardo-monorepo@0.0.0 moon /Users/karstens/Developer/github/adobe/leonardo
> moon "sync" "projects"

✔ Successfully synced 2 projects

and

➜  leonardo git:(karstens/fix--set-node-version-to-lts) pnpm install
Scope: all 3 workspace projects
Lockfile is up to date, resolution step is skipped
Already up to date
. prepare$ husky install
│ husky - Git hooks installed
└─ Done in 397ms
Done in 1.2s