search

adobe / lit-mobx

Mixin and base class for using mobx with lit-element
Apache License 2.0
269 stars 16 forks source link

Upgrade to Lit 3 #167

Closed cristianmadularu closed 11 months ago

cristianmadularu commented 1 year ago

With the release of Lit 3, coud we please also update the mobx lib in order to use it?

image

Thank you

Westbrook commented 1 year ago

Definitely something we'd like to support at some point! Thanks for getting this issue posted.

We'd be happy to accept a PR to modify this to ^2.0.0 || ^3.0.0, but it may be a little while before we're able to go to this on our end.

cristianmadularu commented 1 year ago

Thank you @Westbrook

Would this do it? https://github.com/adobe/lit-mobx/pull/168

cristianmadularu commented 11 months ago

Any update on this? Thank you! Please note that I have created a PR for it.

RoXuS commented 11 months ago

+1

benjamind commented 11 months ago

I'll try and take a look at this soon and get a new version published, am unfortunately laid low with the virus we're all ignoring and I believe @Westbrook is away on vacation.

cristianmadularu commented 11 months ago

Thank you

benjamind commented 11 months ago

This should now be fixed in the v2.2.1 release

cristianmadularu commented 11 months ago

Yup, I just upgraded and it looks good. Thank you @benjamind

benjamind commented 11 months ago

Thanks for the prompt!