search

adobe / openwhisk-action-logger

Logger for openwhisk actions.
Apache License 2.0
1 stars 2 forks source link

Add __CFBundleIdentifier to the list of ignored parameters to trace on macOS #120

Closed dominique-pfister closed 1 year ago

dominique-pfister commented 3 years ago

When starting a debug session, I always see the following being logged in the Debug Console:

Trace: { params: { __CFBundleIdentifier: 'com.googlecode.iterm2' } } before
    at .../node_modules/@adobe/openwhisk-action-logger/src/logger.js:270:9
    at .../node_modules/@adobe/openwhisk-action-logger/src/logger.js:229:12
    at .../node_modules/cls-hooked/context.js:118:13
    at Namespace.run (.../node_modules/cls-hooked/context.js:97:5)
    ...

The environment variable __CFBundleIdentifier seems to have appeared lately and contains the name of the terminal application being used (it reads __CFBundleIdentifier=com.apple.Terminal when using macOS's default terminal).

It would be nice if the list of parameters being ignored in https://github.com/adobe/openwhisk-action-logger/blob/c983a43dbb3dfd88b6d7f7f23638e74232577d0e/src/logger.js#L257-L264 could contain that identifier as well.