More Link Fixes - Githubissues

adobe / parliament-client-template

A template for client projects of the developer documentation site

Apache License 2.0

7 stars 18 forks source link

More Link Fixes #380

Closed chr0n1x closed 2 years ago

chr0n1x commented 2 years ago

Description

use gatsby.Link for course nav
rename a few props in CourseNav and CourseMenu so it's more obvious which variables are being used for what
use withPrefix to account for localstore containing page fullpaths; page objects themselves only have page paths specified in their manifests, no prefixes.

Motivation and Context

Fixes a bug with the CourseNav in course templates.

How Has This Been Tested?

Locally (build + yarn start)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.