adobe / parliament-client-template

A template for client projects of the developer documentation site

Apache License 2.0

7 stars 18 forks source link

disable ligatures in monospace code blocks. #414

Closed sparecycles closed 7 months ago

sparecycles commented 7 months ago

Description

turns off font ligatures in code blocks.

Related Issue

413

Motivation and Context

It looks bad and is harder to read.

How Has This Been Tested?

In the brower, via dev-tools on the class declaration in question.

Screenshots (if appropriate):

Note font-variant-ligatures: no-common-ligatures does not help.

(also note the screen-shot text was also edited in dev-tools, I don't remember where I found the original issue).

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed. 🤞

sparecycles commented 7 months ago

I don't understand the CI failure, if it's checking out pull/414/merge

then it shouldn't need to pull the branch specifically

and it can't find it because it's in my fork. Does this project not accept pull requests from forked repos?