We noticed how Table components show a horizontal show bar always regardless of whether the table overflows its parent container. We fixed this in https://github.com/adobe/parliament-ui-components/pull/200 by setting overflow-x to 'auto'. Besides the horizontal scroll bar, we noticed that table components have a bottom margin. We think we should not add this margin to all tables because of the following reasons.
The margin makes the layout inconsistent - while tables have a bottom margin, they don't have a top margin.
Doc authors cannot remove whitespace but can add it by adding breaklines - so, better too little margin than to much.
How Has This Been Tested?
Ran Parliament locally with this change - table bottom margin gone.
Before
After
Note how there still is some whitespace between the table and the second paragraph. That's not the table's bottom margin but the paragraph's top margin. See the video attached to the pull request description of https://github.com/adobe/parliament-ui-components/pull/200 for a more detailed demonstration.
Screenshots (if appropriate):
See previous section.
Types of changes
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
Related Issue
N/A
Motivation and Context
We noticed how Table components show a horizontal show bar always regardless of whether the table overflows its parent container. We fixed this in https://github.com/adobe/parliament-ui-components/pull/200 by setting overflow-x to 'auto'. Besides the horizontal scroll bar, we noticed that table components have a bottom margin. We think we should not add this margin to all tables because of the following reasons.
How Has This Been Tested?
Ran Parliament locally with this change - table bottom margin gone.
Before
After
Note how there still is some whitespace between the table and the second paragraph. That's not the table's bottom margin but the paragraph's top margin. See the video attached to the pull request description of https://github.com/adobe/parliament-ui-components/pull/200 for a more detailed demonstration.
Screenshots (if appropriate):
See previous section.
Types of changes
Checklist: