adobe / phased-testing

A TestNG plugin that allows tests to be reused in validating System changes such as upgrades or system changes that happen in chaos engineering.
MIT License
7 stars 3 forks source link

[NonInterruptiveEvent]: being able to have a default value for the parameter PHASED.TESTS.PHASE #214

Open mickaelgobbo opened 4 weeks ago

mickaelgobbo commented 4 weeks ago

Expected Behaviour

Currently we have different way to execute different combination of testing with even, but the -DPHASED.TESTS.PHASE parameter is mandatory to being able to execute non interrutive event.

For exemple we can have for now the mode 23 (-DPHASED.TESTS.PHASE='NON_INTERRUPTIVE(23)') to be sure that the event is finished before calling the test method.

We have also the mode 33 (-DPHASED.TESTS.PHASE='NON_INTERRUPTIVE(33)') to call in the same time the event and the test method to allow a completely different scenarion.

Improvement request

We need probably to have a default mode, to being able to trigger test method with even without this parameter.

I think the NON_INTERRUPTIVE(23) should be a good candidate for a default mode, given it's in this mode we have better chance to reproduce the same exactly STR in case of reexecution of test.

mickaelgobbo commented 4 weeks ago

there is indeed a dafault mode which is 33 if we specify the parameter -DPHASED.TESTS.PHASE='NON_INTERRUPTIVE' it's fine so.

baubakg commented 4 weeks ago

This is part of the refactoring #204 I will add this as an item for that issue