adobe / react-spectrum-charts

Build compelling visualizations using declarative react components.

http://opensource.adobe.com/react-spectrum-charts/

Apache License 2.0

65 stars 14 forks source link

feat: bar dimension selection ring #419

Closed rich-b closed 3 weeks ago

rich-b commented 1 month ago

Adds a selection ring for bar charts when highlighting by dimension

Description

When highlighting by dimension, instead of changing the stoke width and color for the bar that was selected, a new selection ring will appear that circles the entire dimension selected.

Related Issue

374

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

github-actions[bot] commented 1 month ago

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-419

rich-b commented 3 weeks ago

Thanks @marshallpete, I made some changes. There is still a slight jitter with the extra 5px removed. I've seen this in other areas as well however.

github-actions[bot] commented 3 weeks ago

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-419

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud