feat: remove 32 padding on linear dimension scales - Githubissues

adobe / react-spectrum-charts

Build compelling visualizations using declarative react components.

http://opensource.adobe.com/react-spectrum-charts/

Apache License 2.0

65 stars 14 forks source link

feat: remove 32 padding on linear dimension scales #442

Closed marshallpete closed 5 days ago

marshallpete commented 6 days ago

Description

Padding existed on linear dimension axes but it was misleading and identified as a design bug. This removes that padding.

Motivation and Context

Existing padding was misleading on continuous data

How Has This Been Tested?

Existing tests pass

Screenshots (if appropriate):

Before:

After:

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

sonarcloud[bot] commented 5 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 5 days ago

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-442