adobe / react-spectrum-charts

Build compelling visualizations using declarative react components.
http://opensource.adobe.com/react-spectrum-charts/
Apache License 2.0
65 stars 14 forks source link

feat: line selection highlighting #443

Open rich-b opened 6 days ago

rich-b commented 6 days ago

Description

Adds selection highlight support to Line charts

Related Issue

374

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

image

image

Types of changes

Checklist:

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

marshallpete commented 5 days ago

Do you mind adding a story that demonstrates this feature?

rich-b commented 3 days ago

@marshallpete the existing story already demonstrates this. the ChartPopover -> LineChart story has a UNSAFE_highlightBy control. It can be set to item(default), series, or dimension. This is the same as what we already have for the ChartPopover -> StackedBarChart story