adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.

https://react-spectrum.adobe.com

Apache License 2.0

13.05k stars 1.13k forks source link

Open LFDanLu opened 3 years ago

LFDanLu commented 3 years ago

🐛 Bug Report

From the latest testing session:

Focus ring indicator appears on Android when using TalkBack to expand/collapse the Accordion rows
Disabled items aren't announced as disabled when using TalkBack/VoiceOver. Disabled items also don't announce their expanded/collapsed state

intergalacticspacehighway commented 3 years ago

@LFDanLu I quickly analyzed this.

Focus ring - This happens as isFocusVisible becomes true due to some reason when Talkback is enabled and a button is pressed using double tap. The same happens with Tabs.
Talkback is picking heading tag's semantics as Button is wrapped using h3. Not sure what should be a better approach here for this fix. Changing role="presentation" of H3 or moving it into the button fixes it (this creates some style issues, but I think that would be an easy fix).

devongovett commented 1 month ago

First point appears to be fixed. Disabled point is still an issue.