adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.

https://react-spectrum.adobe.com

Apache License 2.0

13.11k stars 1.14k forks source link

Action button doesn't seems to have the right padding #4433

Open kamendola opened 1 year ago

kamendola commented 1 year ago

🐛 Bug Report

ActionButton with aria-label="Icon only" appears to be 34px by 32px

🤔 Expected Behavior

ActionButton with aria-label="Icon only" should be 32px by 32px according to the designs specs

💻 Code Sample

https://react-spectrum.adobe.com/react-spectrum/ActionButton.html#accessibility

🧢 Your Company/Team

Adobe Experience Cloud, AEM, Universal Editor

LFDanLu commented 1 year ago

For context: --spectrum-actionbutton-icon-padding-x is returning a value that is 1 extra pixel too large in either direction. I'll have to dig to see if this was on purpose, but I think we should just override the var to return 6px instead of 7px OR update to follow the latest spectrum css for actionbutton