Open charl0tee opened 10 months ago
Hello, we've recently upgraded to React Aria Components version 1.0.0-rc.0
and have noticed that several of our modals are malfunctioning, which we believe is directly related to this issue. Setting the modal dialog's position to relative
as suggested by @charl0tee does not solve the issue for us unfortunately.
@devongovett Could you provide any updates on the resolution of this issue, or suggest any temporary workarounds we might employ in the meantime? Thank you! ๐
@clemensheithecker FYI, in our case a workaround is to change the Modal to a controlled Modal, so we don't need to import the DialogTrigger
anymore (which was the one causing issues when added around a TooltipTrigger
)
Assuming I've understood correctly that the Dialog is not showing up at all. This should be fixed by https://github.com/adobe/react-spectrum/pull/5526 As seen here: https://codesandbox.io/p/sandbox/stoic-perlman-dk6qlp?file=%2Fsrc%2FApp.js
I did notice the close button inside the modal isn't working. Not sure why yet, so would like to leave this Issue open for the time being.
Provide a general summary of the issue here
We have a button triggering both a Tooltip and a Modal. When the modal has a position
fixed
orabsolute
it's closing it automatically adding thedata-exiting="true"
at the same time than thedata-entering="true"
. If I remove the TooltipTrigger around the button, or if the Modal is in positionrelative
, then it works.๐ค Expected Behavior?
The Modal should remain visible if we haven't clicked on any closing button
๐ฏ Current Behavior
The Modal is opening and closing directly.
๐ Possible Solution
My guess is there are some sort of conflict with the Tooltip and Modal portals, and the
is-exiting
should probably be on the tooltip and not on the modal ?๐ฆ Context
No response
๐ฅ๏ธ Steps to Reproduce
Here is our code for better understanding :
Version
react-aria-components => 1.0.0-beta.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
MacOS
๐งข Your Company/Team
No response
๐ท Tracking Issue
No response