adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
12.95k stars 1.12k forks source link

Heads-up: repo can't be installed with Node.js 22 #6380

Open wojtekmaj opened 5 months ago

wojtekmaj commented 5 months ago

Provide your feedback here.

The repository fails to install on Node.js 22, soon to become a widely used LTS version.

The cause is eslint-plugin-jsdoc which has engines specified as "node": "^14 || ^16 || ^17 || ^18 || ^19". Latest version, in turn, has it set to "node": ">=18", while minimum Node.js version currently supported by this repo for development is 14.15.0.

🔦 Context

This can cause unnecessary disruptions for collaborators.

💻 Code Sample

No response

Version

n/a

What browsers are you seeing the problem on?

Other

If other, please specify

n/a

What operating system are you using?

macOS Sonoma

snowystinger commented 5 months ago

Unfortunately it looks like more than just eslint-plugin-jsdoc is problematic. node-gyp and everything which depends on it fails.

One of the things depending on node-gyp is lerna, which we should be able to remove once we update to Yarn 4

PR to discover issues here: https://github.com/adobe/react-spectrum/pull/6385