adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
12.21k stars 1.07k forks source link

Circular dependency warnings when building #6394

Open gunnx opened 2 months ago

gunnx commented 2 months ago

Provide a general summary of the issue here

When building our application we get warnings from packages used by React Aria:

๐Ÿค” Expected Behavior?

No errors during build

๐Ÿ˜ฏ Current Behavior

Errors shown :

Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/@internationalized/date/dist/utils.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/queries.mjs -> node_modules/@internationalized/date/dist/conversion.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/string.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/react-aria-components/dist/Dialog.mjs -> node_modules/react-aria-components/dist/Popover.mjs -> node_modules/react-aria-components/dist/Dialog.mjs

๐Ÿ’ Possible Solution

Shared functions or types might require to be moved out to be imported separately or import paths changed

๐Ÿ”ฆ Context

No response

๐Ÿ–ฅ๏ธ Steps to Reproduce

Install react-aria-components 1.2.0

import { Button as AriaButton, DateInput as AriaDateInput, DatePicker as AriaDatePicker, DateSegment as AriaDateSegment, Dialog as AriaDialog, Group as AriaGroup, Popover as AriaPopover, DateValue } from 'react-aria-components';

run a build , we use rollup and errors are showing during the bundling

Version

react-aria-components@1.2.0

What browsers are you seeing the problem on?

Firefox

If other, please specify.

No response

What operating system are you using?

Mac

๐Ÿงข Your Company/Team

No response

๐Ÿ•ท Tracking Issue

No response

pboling commented 1 month ago

Using vite we get similar warnings:

[WebServer] Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs
[WebServer] Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/utils.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/queries.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/string.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
snowystinger commented 1 month ago

linking relevant issue from rollup https://github.com/rollup/rollup/issues/1089