Expose FocusableProvider from monopackage

snowystinger commented 1 week ago

Closes https://github.com/adobe/react-spectrum/issues/6574

Is this something we want to expose? Docs?

✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

LFDanLu commented 1 week ago

I still feel a bit iffy about exposing FocusableProvider since it feels like using this provider may cause various props to unintentionally be added to components that have useFocusable called for them under the hood via their hooks. Users would need to make sure only to just wrap the TooltipTrigger children with it, which isn't so bad since that seem to be the only use case for it right now but that could potentially change in the future. Maybe since the current usage is so limited to specifically tooltips we could perhaps instead tweak the hooks or add a solely tooltip specific way of propagating the pointerEnter/other props from useTooltipTrigger to tooltip button?

snowystinger commented 1 week ago

Linking another comment from a confused user https://github.com/adobe/react-spectrum/issues/1175#issuecomment-2083073184

adobe / react-spectrum