search

adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
12.72k stars 1.09k forks source link

fix: prevent classname to be overwritten in color swatch component #6584

Closed CHE1RON closed 3 months ago

CHE1RON commented 3 months ago

Closes #6583

CHE1RON commented 3 months ago

Not sure I did it right @snowystinger, but the failing test seems to be coming from somewhere else .. ?

reidbarber commented 3 months ago

It looks like lint is just failing because the imports need to be sorted.

CHE1RON commented 3 months ago

Thanks for reminding me, I committed again but now I don't know what the linter wants me to do 😅

yihuiliao commented 3 months ago

Pushed up a couple of fixes for the lint, hope you don't mind! Thanks for the PR :))

CHE1RON commented 3 months ago

@yihuiliao thanks very much! it's my first contribution to the project, but I'm picking things up fast 😅

CHE1RON commented 3 months ago

Thanks everyone!