Open snowystinger opened 4 days ago
Build successful! ๐
Just a FYI, I pulled this into my load more branch locally for S2 development and verified that it fixed most of the lint issues except for this last numberfield one which I didn't look into yet:
src/NumberField.tsx(371,44): error TS2769: No overload matches this call.
[0] The last overload gave the following error.
[0] Argument of type '{ elementType: "div"; form?: string | undefined; formAction?: string | undefined; formEncType?: string | undefined; formMethod?: string | undefined; formNoValidate?: boolean | undefined; ... 32 more ...; style?: CSSProperties | ... 1 more ... | undefined; }' is not assignable to parameter of type 'AriaButtonOptions<ElementType>'.
[0] Types of property 'onPress' are incompatible.
[0] Type '((e: import("/Users/danilu/dev/experimental-s2/node_modules/react-aria-components/node_modules/@react-types/shared/src/events").PressEvent) => void) | undefined' is not assignable to type '((e: import("/Users/danilu/dev/experimental-s2/node_modules/@react-types/shared/src/events").PressEvent) => void) | undefined'.
[0] Type '(e: import("/Users/danilu/dev/experimental-s2/node_modules/react-aria-components/node_modules/@react-types/shared/src/events").PressEvent) => void' is not assignable to type '(e: import("/Users/danilu/dev/experimental-s2/node_modules/@react-types/shared/src/events").PressEvent)
Build successful! ๐
Closes
Found in Daniel's work, this adds needed compatibility between React 18 and 19 types. See https://github.com/microsoft/TypeScript/issues/59049
โ Pull Request Checklist:
๐ Test Instructions:
๐งข Your Project: